Added contactable to tracks #2541

rishabhptr · 2019-06-13T18:25:00Z

Related to #2528

I have tried couple of different ways to use the contact model for social media fields. I have chosem this approach so as to enable for the user to add all fields at the same time in a single form while creating the track using nested attributes.

Also, as contact model has a has_one relationship with conference model I need to pass the conference_id as it is mandatory but I believe this will break the previous mechanism where a conference had one contact which could be fetched to show on the splashpage. So we would need to modify this relationship as well.

At this point I need to decide if I should use this model or just add the social fields in the main Track/Booth model itself.

Apart from this other fields like :code_of_conduct_accepted, :additional_requirements etc are pretty straightforward and after this I can work on the different views related to these details.

codecov · 2019-06-16T04:31:41Z

Codecov Report

Merging #2541 into master will decrease coverage by 14.84%.
The diff coverage is 18.18%.

@@             Coverage Diff             @@
##           master    #2541       +/-   ##
===========================================
- Coverage   76.46%   61.62%   -14.85%     
===========================================
  Files         146      146               
  Lines        4810     5016      +206     
===========================================
- Hits         3678     3091      -587     
- Misses       1132     1925      +793

Impacted Files	Coverage Δ
app/controllers/tracks_controller.rb	`0% <0%> (-97.37%)`	⬇️
app/models/track.rb	`94.95% <100%> (-4.2%)`	⬇️
app/models/contact.rb	`77.77% <100%> (+2.77%)`	⬆️
...p/controllers/admin/ticket_scannings_controller.rb	`0% <0%> (-100%)`	⬇️
app/controllers/api/v1/rooms_controller.rb	`0% <0%> (-100%)`	⬇️
app/controllers/api/v1/events_controller.rb	`0% <0%> (-100%)`	⬇️
app/controllers/api/v1/conferences_controller.rb	`0% <0%> (-100%)`	⬇️
app/controllers/api/base_controller.rb	`0% <0%> (-100%)`	⬇️
app/controllers/api/v1/tracks_controller.rb	`0% <0%> (-100%)`	⬇️
app/controllers/confirmations_controller.rb	`0% <0%> (-100%)`	⬇️
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b12830...739fe62. Read the comment docs.

codecov · 2019-06-16T04:31:41Z

Codecov Report

Merging #2541 into GSoC19 will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           GSoC19    #2541      +/-   ##
==========================================
+ Coverage   82.29%   82.33%   +0.04%     
==========================================
  Files         147      147              
  Lines        4795     4801       +6     
==========================================
+ Hits         3946     3953       +7     
+ Misses        849      848       -1

Impacted Files	Coverage Δ
app/controllers/tracks_controller.rb	`97.56% <100%> (+0.19%)`	⬆️
app/models/track.rb	`99.16% <100%> (+0.01%)`	⬆️
app/models/contact.rb	`88.88% <100%> (+1.38%)`	⬆️
app/controllers/commercials_controller.rb	`96.42% <0%> (+3.57%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 770a63e...465976b. Read the comment docs.

differentreality · 2019-06-16T09:36:13Z

Please do correct me if I am wrong, but I don't think we are providing an option for people to submit information such as the project's source code location or the project's license.

rishabhptr · 2019-06-16T12:20:19Z

@differentreality The Social Media fields covers the different platforms and yes there is no specific fields for the code repository. I intended to have a website_url, email , github/repo fields in the track model itself and use the contact model for capture the media platforms.

But I liked the idea for project license, but should we add a special field for this?

The other information apart from these in the track submission that I propose are :
:code_of_conduct_accepted boolean
:additional_requirements string
size integer

:track_type - which can be selected from a drop down with choices much like event_types which I will cover in my next PR.

These are the details that I am planning to include in the submission from the users for tracks.

Ana06

the branch to which you submit your changes should be openSUSE:GSoC19. The code LGTM 👍

Ana06 · 2019-06-17T08:50:43Z

db/schema.rb

+ActiveRecord::Schema.define(version: 20190612161235) do
+
+  # These are extensions that must be enabled in order to support this database
+  enable_extension "plpgsql"


Why is this here? In general, why does this file have that many changes?

I think some unwanted changes were introduced during db migrations . I will check it again in my new PR against the GSoC19 branch.

differentreality · 2019-06-20T12:57:39Z

@rishabhptr so what are you suggesting for the other links we want to show (email, license, etc)? Add fields in Track model? And then in Booth model?

rishabhptr · 2019-06-20T13:44:33Z

@differentreality As of now yes, any specific field like email, website/license which we can identify would go in the track/booth model itself.

Ana06 · 2019-06-27T16:26:36Z

@differentreality can we get this merged or are there still concerns?

@rishabh92 can you please rebase? there are some commits that shouldn't be here.

We should fix #2540 because is blocking the PRs as well.

differentreality · 2019-07-17T19:38:18Z

@rishabhptr please keep an eye out on Travis and fix the linters failures, we cannot merge ortherwise!

rishabhptr · 2019-07-19T13:26:12Z

@differentreality I have fixed the linters, but the feature test were failing due to the webdriver issue which is now resolved in master. Maybe we should bring in the latest changes to the GSoC19 branch?

differentreality · 2019-07-21T10:04:11Z

@differentreality can we get this merged or are there still concerns?

@Ana06 not concerns per se, but we will probably need to use the same fields for Booth as well.

differentreality

The tracks#new form is now quite longer, making it less easy/pleasant for someone to submit a track proposal

differentreality · 2019-07-21T11:43:16Z

Screenshots would be helpful here too 😉

differentreality · 2019-07-21T19:26:42Z

@rishabhptr please rebase

Added social media fields to track submission form by using a polymorphic association with the Contact Model.

rishabhptr · 2019-08-09T13:27:10Z

@differentreality Yes, the form is quite longer now. Maybe we could ask for the other fields at a later stage.

Right now when the track is accepted and then confirmed by the submitter, the user is able to manage his track but he cannot edit the details as it make sense to not change them after submission.

However, we can include the option to add fields such as social media in a separate tab in the show page. So that the user can update these details there.

As for booths, we can allow the user to edit his submission add these additional information upon being accepted and not before.

rishabhptr force-pushed the contactable branch from 521459c to 739fe62 Compare June 16, 2019 04:31

hennevogel deployed to osem-demo-pr-2541 June 16, 2019 09:27 View deployment

Ana06 reviewed Jun 17, 2019

View reviewed changes

rishabhptr changed the base branch from master to GSoC19 June 18, 2019 07:07

rishabhptr force-pushed the contactable branch from 739fe62 to 023bb7f Compare June 28, 2019 06:50

Ana06 added the GSoC GSoC 19 related issues/PR label Jul 4, 2019

rishabhptr force-pushed the contactable branch from 023bb7f to a8c745f Compare July 19, 2019 13:03

rishabhptr closed this Jul 19, 2019

rishabhptr reopened this Jul 19, 2019

rishabhptr force-pushed the contactable branch from a8c745f to 1f170db Compare July 21, 2019 09:40

rishabhptr closed this Jul 21, 2019

rishabhptr reopened this Jul 21, 2019

rishabhptr force-pushed the contactable branch 2 times, most recently from 769fc41 to 4232dd8 Compare July 21, 2019 10:07

differentreality reviewed Jul 21, 2019

View reviewed changes

Add contactable to tracks

465976b

Added social media fields to track submission form by using a polymorphic association with the Contact Model.

rishabhptr force-pushed the contactable branch from 4232dd8 to 465976b Compare July 22, 2019 05:26

differentreality merged commit a96722b into openSUSE:GSoC19 Oct 24, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added contactable to tracks #2541

Added contactable to tracks #2541

rishabhptr commented Jun 13, 2019 •

edited

Loading

codecov bot commented Jun 16, 2019

codecov bot commented Jun 16, 2019 •

edited

Loading

differentreality commented Jun 16, 2019

rishabhptr commented Jun 16, 2019 •

edited

Loading

Ana06 left a comment

Ana06 Jun 17, 2019

rishabhptr Jun 17, 2019

differentreality commented Jun 20, 2019

rishabhptr commented Jun 20, 2019

Ana06 commented Jun 27, 2019

differentreality commented Jul 17, 2019

rishabhptr commented Jul 19, 2019 •

edited

Loading

differentreality commented Jul 21, 2019

differentreality left a comment

differentreality commented Jul 21, 2019

differentreality commented Jul 21, 2019

rishabhptr commented Aug 9, 2019 •

edited

Loading

Added contactable to tracks #2541

Added contactable to tracks #2541

Conversation

rishabhptr commented Jun 13, 2019 • edited Loading

codecov bot commented Jun 16, 2019

Codecov Report

codecov bot commented Jun 16, 2019 • edited Loading

Codecov Report

differentreality commented Jun 16, 2019

rishabhptr commented Jun 16, 2019 • edited Loading

Ana06 left a comment

Choose a reason for hiding this comment

Ana06 Jun 17, 2019

Choose a reason for hiding this comment

rishabhptr Jun 17, 2019

Choose a reason for hiding this comment

differentreality commented Jun 20, 2019

rishabhptr commented Jun 20, 2019

Ana06 commented Jun 27, 2019

differentreality commented Jul 17, 2019

rishabhptr commented Jul 19, 2019 • edited Loading

differentreality commented Jul 21, 2019

differentreality left a comment

Choose a reason for hiding this comment

differentreality commented Jul 21, 2019

differentreality commented Jul 21, 2019

rishabhptr commented Aug 9, 2019 • edited Loading

rishabhptr commented Jun 13, 2019 •

edited

Loading

codecov bot commented Jun 16, 2019 •

edited

Loading

rishabhptr commented Jun 16, 2019 •

edited

Loading

rishabhptr commented Jul 19, 2019 •

edited

Loading

rishabhptr commented Aug 9, 2019 •

edited

Loading